hussein-awala commented on code in PR #29809:
URL: https://github.com/apache/airflow/pull/29809#discussion_r1139851471
##########
airflow/kubernetes/kube_client.py:
##########
@@ -107,23 +110,36 @@ def get_kube_client(
if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):
_enable_tcp_keepalive()
+ new_client_config = _get_default_configuration()
+ api_client_retry_configuration = conf.getjson("kubernetes",
"api_client_retry_configuration", fallback={})
+
+ if not conf.getboolean("kubernetes_executor", "verify_ssl"):
+ _disable_verify_ssl()
+
+ if isinstance(api_client_retry_configuration, dict):
+ new_client_config.retries =
urllib3.util.Retry(**api_client_retry_configuration)
+ elif isinstance(api_client_retry_configuration, unittest.mock.MagicMock):
Review Comment:
You cannot do this to fix unit tests, you should add the config in all the
failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
