jedcunningham commented on code in PR #30214:
URL: https://github.com/apache/airflow/pull/30214#discussion_r1143715322
##########
chart/values.yaml:
##########
@@ -59,6 +59,8 @@ images:
airflow:
repository: ~
tag: ~
+ # Specifying digest takes precedence over tag.
Review Comment:
You also need this in values.schema.yaml.
##########
chart/templates/_helpers.yaml:
##########
@@ -248,8 +248,15 @@ If release name contains chart name it will be used as a
full name.
{{- end }}
# This helper will change when customers deploy a new image.
-{{ define "airflow_image" -}}
-{{ printf "%s:%s" (.Values.images.airflow.repository | default
.Values.defaultAirflowRepository) (.Values.images.airflow.tag | default
.Values.defaultAirflowTag) }}
+{{- define "airflow_image" -}}
+{{- $repository := .Values.images.airflow.repository | default
.Values.defaultAirflowRepository -}}
+{{- $tag := .Values.images.airflow.tag | default .Values.defaultAirflowTag -}}
+{{- $digest := .Values.images.airflow.digest -}}
Review Comment:
We should also have a `defaultAirflowDigest`, and update
`default_airflow_image` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
