elongl commented on code in PR #30214:
URL: https://github.com/apache/airflow/pull/30214#discussion_r1143721758
##########
chart/templates/_helpers.yaml:
##########
@@ -248,8 +248,15 @@ If release name contains chart name it will be used as a
full name.
{{- end }}
# This helper will change when customers deploy a new image.
-{{ define "airflow_image" -}}
-{{ printf "%s:%s" (.Values.images.airflow.repository | default
.Values.defaultAirflowRepository) (.Values.images.airflow.tag | default
.Values.defaultAirflowTag) }}
+{{- define "airflow_image" -}}
+{{- $repository := .Values.images.airflow.repository | default
.Values.defaultAirflowRepository -}}
+{{- $tag := .Values.images.airflow.tag | default .Values.defaultAirflowTag -}}
+{{- $digest := .Values.images.airflow.digest -}}
Review Comment:
That means that the chart will always use the digest rather than the tag.
I think it's preferable that when doing `kubectl describe pod` it'll show
`airflow:2.5.1` rather than `airflow@sha256:...`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
