jedcunningham commented on code in PR #29926:
URL: https://github.com/apache/airflow/pull/29926#discussion_r1145483497
##########
airflow/configuration.py:
##########
@@ -1531,9 +1531,9 @@ def initialize_config() -> AirflowConfigParser:
if local_conf.getboolean("core", "unit_test_mode"):
local_conf.load_test_config()
- # Make it no longer a proxy variable, just set it to an actual string
+ # The conf.get should provide the default_config in case the value is not
set in webserver configs
Review Comment:
```suggestion
```
Don't think we need this comment, that's always the behavior of `get`.
##########
airflow/config_templates/config.yml:
##########
@@ -1264,6 +1264,14 @@ hive:
webserver:
description: ~
options:
+ config_file:
+ description: |
+ Path of webserver_config.py file used for configuring the webserver
parameters with
+ respect to the AIRFLOW_HOME
Review Comment:
```suggestion
Path of webserver_config.py file used for configuring the webserver
parameters
```
It can really be anywhere, so you can drop that part of it.
##########
airflow/config_templates/config.yml:
##########
@@ -1264,6 +1264,14 @@ hive:
webserver:
description: ~
options:
+ config_file:
+ description: |
+ Path of webserver_config.py file used for configuring the webserver
parameters with
+ respect to the AIRFLOW_HOME
Review Comment:
We might even consider not having `webserver_config.py` in the description
either, since it really could be named anything now!
##########
tests/www/views/test_views.py:
##########
@@ -62,6 +62,13 @@ def test_configuration_expose_config(admin_client):
check_content_in_response(["Airflow Configuration"], resp)
[email protected](os.environ, {"AIRFLOW__WEBSERVER_CONFIG_FILE":
"{AIRFLOW_HOME}/config/webserver_config.py"})
Review Comment:
You're missing an `_`, try with `AIRFLOW__WEBSERVER__CONFIG_FILE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
