jedcunningham commented on code in PR #29926:
URL: https://github.com/apache/airflow/pull/29926#discussion_r1149828626
##########
tests/www/views/test_views.py:
##########
@@ -62,6 +62,22 @@ def test_configuration_expose_config(admin_client):
check_content_in_response(["Airflow Configuration"], resp)
[email protected](os.environ, {"AIRFLOW__WEBSERVER__CONFIG_FILE":
"/tmp/my_custom_webserver_config.py"})
+def test_webserver_configuration_config_file(admin_client):
+ conf = initialize_config()
+ conf.validate()
+
+ assert WEBSERVER_CONFIG == os.path.join(AIRFLOW_HOME,
"webserver_config.py")
Review Comment:
Why does this pass? Shouldn't it be your new name instead?
##########
tests/www/views/test_views.py:
##########
@@ -62,6 +62,22 @@ def test_configuration_expose_config(admin_client):
check_content_in_response(["Airflow Configuration"], resp)
[email protected](os.environ, {"AIRFLOW__WEBSERVER__CONFIG_FILE":
"/tmp/my_custom_webserver_config.py"})
+def test_webserver_configuration_config_file(admin_client):
+ conf = initialize_config()
+ conf.validate()
+
+ assert WEBSERVER_CONFIG == os.path.join(AIRFLOW_HOME,
"webserver_config.py")
+
+ # new webserver config is created in this path
+ config_path = os.path.join("/tmp", "my_custom_webserver_config.py")
+
+ assert os.path.isfile(config_path)
+
+ if os.path.isfile(config_path):
+ os.remove(config_path)
Review Comment:
Maybe use tmp_path instead of having to handle cleanup explicitly? You'll
have to move your mocking around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
