jaketf commented on a change in pull request #5602: [AIRFLOW-4983] 
Feature/dataflow operator python3
URL: https://github.com/apache/airflow/pull/5602#discussion_r305015491
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_dataflow_hook.py
 ##########
 @@ -34,8 +34,12 @@
 
 # This is the default location
 # https://cloud.google.com/dataflow/pipelines/specifying-exec-params
+
 DEFAULT_DATAFLOW_LOCATION = 'us-central1'
 
+# These are the supported python interpreters
+DATAFLOW_SUPPORTED_PY_INTERPRETERS = {'python2', 'python3'}
 
 Review comment:
   Is there a way we can submit a python dataflow job w/o having to invoke the 
pipeline script client side? 
   If we could just provide a payload to Dataflow API saying "hey use this 
python version and run this python file (ie. on gcs)". 
   This might allow for a more flexible design for this operator (though a 
significant re structuring).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to