jaketf commented on a change in pull request #5602: [AIRFLOW-4983]
Feature/dataflow operator python3
URL: https://github.com/apache/airflow/pull/5602#discussion_r306365774
##########
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##########
@@ -369,7 +379,7 @@ def start_template_dataflow(self, job_name, variables,
parameters, dataflow_temp
name, variables, parameters, dataflow_template)
def start_python_dataflow(self, job_name, variables, dataflow, py_options,
- append_job_name=True):
+ py_interpreter=None, append_job_name=True):
Review comment:
while airflow may be ready to deprecate python2 support, most python beam
pipelines are authored in python2.
Are you suggesting `py_interpreter` should be a required argument rather
than defaulting to python2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
