mik-laj commented on a change in pull request #5606: [AIRFLOW-4074] Cannot put labels on Cloud Dataproc jobs URL: https://github.com/apache/airflow/pull/5606#discussion_r305040566
########## File path: pylintrc ########## @@ -324,7 +324,7 @@ dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_| # Argument names that match this expression will be ignored. Default to name # with leading underscore. -ignored-argument-names=_.*|^ignored_|^unused_ +ignored-argument-names=_.*|^ignored_|^unused_|^kwargs|^args|^mock_.+ Review comment: This is part of: https://github.com/apache/airflow/pull/5586 Can you look at this? I recommended to copy this line of code, because this PR has no open discussions and I was hoping it would be quickly merged. Otherwise, we would have inconsistently named function arguments. I prefer when the tests do not have function arguments that do not have a high value. Unfortunately, mock always requires arguments in tests ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
