mik-laj commented on a change in pull request #5606: [AIRFLOW-4074] Cannot put 
labels on Cloud Dataproc jobs
URL: https://github.com/apache/airflow/pull/5606#discussion_r305042865
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_dataproc_hook.py
 ##########
 @@ -208,13 +209,24 @@ def __init__(self, project_id, task_id, cluster_name, 
job_type, properties):
                 "placement": {
                     "clusterName": cluster_name
                 },
+                "labels": {'airflow-version': 'v' + version.replace('.', 
'-').replace('+', '-')},
 
 Review comment:
   We have to add these improvements in a few other places also. It would be 
great to see what is doing GCP activities.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to