potiuk commented on PR #30315: URL: https://github.com/apache/airflow/pull/30315#issuecomment-1486380718
I think I finally got that one sorted out and I hope it will get green this time. As discussed before this one is to prevent what happened already where some tests were skipped from being pytest collected because they did not follow the `test_*` convention for our module names: see https://github.com/apache/airflow/pull/30311 and https://github.com/apache/airflow/pull/30306 Look at the description if you are curious- I had to do a lot of small fixes here and there to mitigate mostly the problem that assert rewrite works a bit too aggressively when python_files = `*.py`. Assert rewrite works in the way that it modifies python bytecode after it is generated and sometimes it either fails (mostly when the code being rewritten comes from optimized Cython-generated code). I had to patch cassandra code in our image (!) (and raised a PR to cassandra-driver) but I also added a mechanism to separate out tests that do not work well with assert rewriting (`PlainAsserts` test type and PYTEST_PLAIN_ASSERTS env variable to skip such tests). Have fun with review. @hussein-awala @Taragolis @ashb @eladkal @pierrejeambrun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
