Taragolis commented on PR #30315:
URL: https://github.com/apache/airflow/pull/30315#issuecomment-1486677804

   Not only module name could be the reason that tests are not collected. The 
also other naming conventions also could be a reason, and we also have it in 
the past when test class doesn't start with `Test*`
   
   [We have additional 
check](https://github.com/apache/airflow/blob/28f73e42721bba5c5ad40bb547be9c057ca81030/tests/always/test_project_structure.py#L56)
 that tests exists for appropriate airflow modules, however it broken [for a 
very long 
time](https://github.com/apache/airflow/pull/28459#discussion_r1052116651) and 
some of the modules doesn't follow this naming convention.
   
   I do not have any concern about scan all files if it safe, I really do not 
know how it affects to `conftest.py` and other modules which use only as a 
helpers but could have some side effects.
   
   May be just better follow naming conventions (this sample only cover regular 
airflow parts but not breeze, k8s and charts test) and check it again:
   1. `airflow.awesome.module` -> `tests.awesome.test_module` or 
`tests.integration.awesome.test_module`
   2. `airflow.providers.awesome.module` -> 
`tests.providers.awesome.test_module` or 
`tests.providers.integration.awesome.test_module`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to