uranusjr commented on code in PR #30361:
URL: https://github.com/apache/airflow/pull/30361#discussion_r1152966771
##########
airflow/executors/base_executor.py:
##########
@@ -216,6 +215,8 @@ def heartbeat(self) -> None:
self.log.debug("%s in queue", num_queued_tasks)
self.log.debug("%s open slots", open_slots)
+ from airflow.stats import Stats
Review Comment:
Do this and the `exceptions` imports really affact import time much?
From what I can tell these modules are very barebone and should only cost a
fraction to import? And the pure import time save seems marginal at best since
they need to be imported for pretty much anything anywhere for the executor to
be actually useful.
Other import changes all make sense to me, I only wonder about these
specific two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
