jedcunningham commented on code in PR #30270:
URL: https://github.com/apache/airflow/pull/30270#discussion_r1153568131
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -171,6 +186,7 @@ def _is_relevant_upstream(upstream: TaskInstance) -> bool:
for finished_ti in
dep_context.ensure_finished_tis(ti.get_dagrun(session), session)
if _is_relevant_upstream(finished_ti)
)
+ finished_upstream_tis = list(finished_upstream_tis)
Review Comment:
Why not do a list comprehension right above here instead? Does this actually
need to be a list?
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -390,5 +420,35 @@ def _iter_upstream_conditions() ->
Iterator[ColumnOperators]:
f"upstream_task_ids={task.upstream_task_ids}"
)
)
+ elif trigger_rule == TR.ALL_DONE_SETUP_SUCCESS:
+ status = None
+ if not upstream_done:
+ status = self._failing_status(
Review Comment:
```suggestion
yield self._failing_status(
```
Should these just be yielding from here? Does the extra variable buy us
anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
