potiuk commented on code in PR #30308:
URL: https://github.com/apache/airflow/pull/30308#discussion_r1154641879
##########
airflow/jobs/base_job.py:
##########
@@ -175,10 +155,6 @@ def kill(self, session=None):
def on_kill(self):
"""Will be called when an external kill command is received."""
- @provide_session
- def heartbeat_callback(self, session=None) -> None:
- """Callback that is called during heartbeat. This method should be
overwritten."""
-
def heartbeat(self, only_if_necessary: bool = False):
Review Comment:
Yes. Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
