[GitHub] [airflow] uranusjr commented on a diff in pull request #30308: Separate and split run job method into prepare/execute/complete steps

Tue, 11 Apr 2023 01:09:19 -0700 


uranusjr commented on code in PR #30308:
URL: https://github.com/apache/airflow/pull/30308#discussion_r1162450373


##########
airflow/jobs/job.py:
##########
@@ -292,3 +281,51 @@ def most_recent_job(job_type: str, session: Session = 
NEW_SESSION) -> Job | None
         )
         .first()
     )
+
+
+@provide_session
+def prepare_for_execution(job: Job | JobPydantic, session: Session = 
NEW_SESSION):

Review Comment:
   This and `complete_execution` don’t seem to ever take a `JobPydantic`, only 
`Job`? Actually the two can be removed entirely, from what I can tell, since 
`run_job` (the only place these two are called) can simply call the method on 
`Job` directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to