slmg commented on PR #30423: URL: https://github.com/apache/airflow/pull/30423#issuecomment-1493144668
However I just realised there was thoughts behind the current idea of creating Redis secrets even without using `Celery*Executor`: https://github.com/apache/airflow/blob/484a7d0ca07ce594861a5989ec3f939756de0389/chart/templates/secrets/redis-secrets.yaml#L18-L23 It seems my brain is too well trained to skip copyright headers! :sweat_smile: I wonder if this is still needed? What does "(if necessary)" mean in the above? What would be the best course of action? I am not willing to use Celery/Redis so it definitely feels buggy to always deploy these secrets. Based on the chart config, it would be possible to disable at least *the Redis password secret* with the following values.yaml: ```yaml redis: enabled: false ``` That feels a bit redundant given Redis resources do not get created in the context of a `KubernetesExecutor`, but it might be preferable over creating un-needed resources, if that's the way we should go. I could perhaps add a check to `.Values.redis.enabled` to the broker-url secret as well? So we won't have a world where only one redis secret gets created? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
