jedcunningham commented on PR #30423: URL: https://github.com/apache/airflow/pull/30423#issuecomment-1500781210
Hmm, I wrote the "if necessary" :) I meant if [this](https://github.com/apache/airflow/blob/0fe73c2e8c0ca90faf54b39139ffab5769f4cca1/chart/templates/secrets/redis-secrets.yaml#L29) and [this](https://github.com/apache/airflow/blob/0fe73c2e8c0ca90faf54b39139ffab5769f4cca1/chart/templates/secrets/redis-secrets.yaml#L53) are true. Broker url is a bit different than the redis password. The redis password is used by redis itself, where Airflow uses the broker url. In the KubernetesExecutor -> CeleryExecutor situation, you'll still need the broker url even when using an external redis `redis.enabled=false`. Though, one could argue how useful the pre-install created secret is, as it may not have the right password anyways. It feels a little odd, but I think it's right as-is? It sounds hacky, but wouldn't setting `data.brokerUrlSecretName=foo` prevent this secret from getting created? I could see an argument for having something similar to `enableBuiltInSecretEnvVars` for these. Something to consider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
