lwyszomi commented on PR #30403:
URL: https://github.com/apache/airflow/pull/30403#issuecomment-1493700762

   > cc: @lwyszomi
   > 
   > BTW. vendoring-in google-ads immmediately frees a lot of other 
dependencies in our constraints
   > 
   > ```
   > < # This constraints file was automatically generated on 
2023-03-31T06:33:43Z
   > ---
   > > # This constraints file was automatically generated on 
2023-03-31T19:06:44Z
   > 43a44
   > > Shapely==1.8.5.post1
   > 188,189c189
   > < google-ads==18.0.0
   > < google-api-core==2.8.2
   > ---
   > > google-api-core==2.11.0
   > 194,204c194,204
   > < google-cloud-aiplatform==1.16.1
   > < google-cloud-appengine-logging==1.1.3
   > < google-cloud-audit-log==0.2.4
   > < google-cloud-automl==2.8.0
   > < google-cloud-bigquery-datatransfer==3.7.0
   > < google-cloud-bigquery-storage==2.14.1
   > < google-cloud-bigquery==2.34.4
   > < google-cloud-bigtable==2.11.1
   > < google-cloud-build==3.9.0
   > < google-cloud-compute==0.7.0
   > < google-cloud-container==2.11.1
   > ---
   > > google-cloud-aiplatform==1.23.0
   > > google-cloud-appengine-logging==1.3.0
   > > google-cloud-audit-log==0.2.5
   > > google-cloud-automl==2.11.1
   > > google-cloud-bigquery-datatransfer==3.11.1
   > > google-cloud-bigquery-storage==2.19.1
   > > google-cloud-bigquery==3.9.0
   > > google-cloud-bigtable==2.17.0
   > > google-cloud-build==3.14.0
   > > google-cloud-compute==1.11.0
   > > google-cloud-container==2.18.0
   > 206,213c206,213
   > < google-cloud-datacatalog==3.9.0
   > < google-cloud-dataflow-client==0.5.4
   > < google-cloud-dataform==0.2.0
   > < google-cloud-dataplex==1.1.0
   > < google-cloud-dataproc-metastore==1.6.0
   > < google-cloud-dataproc==5.0.0
   > < google-cloud-dlp==3.8.0
   > < google-cloud-kms==2.12.0
   > ---
   > > google-cloud-datacatalog==3.12.0
   > > google-cloud-dataflow-client==0.8.3
   > > google-cloud-dataform==0.5.1
   > > google-cloud-dataplex==1.4.3
   > > google-cloud-dataproc-metastore==1.10.1
   > > google-cloud-dataproc==5.4.1
   > > google-cloud-dlp==3.12.1
   > > google-cloud-kms==2.16.1
   > 215,222c215,222
   > < google-cloud-logging==3.2.1
   > < google-cloud-memcache==1.4.1
   > < google-cloud-monitoring==2.11.0
   > < google-cloud-orchestration-airflow==1.4.1
   > < google-cloud-os-login==2.7.1
   > < google-cloud-pubsub==2.13.5
   > < google-cloud-redis==2.9.0
   > < google-cloud-resource-manager==1.6.0
   > ---
   > > google-cloud-logging==3.5.0
   > > google-cloud-memcache==1.7.1
   > > google-cloud-monitoring==2.14.2
   > > google-cloud-orchestration-airflow==1.7.1
   > > google-cloud-os-login==2.9.1
   > > google-cloud-pubsub==2.15.2
   > > google-cloud-redis==2.12.1
   > > google-cloud-resource-manager==1.9.1
   > 227c227
   > < google-cloud-tasks==2.10.1
   > ---
   > > google-cloud-tasks==2.13.1
   > 232c232
   > < google-cloud-workflows==1.7.1
   > ---
   > > google-cloud-workflows==1.10.1
   > 235c235
   > < googleapis-common-protos==1.56.4
   > ---
   > > googleapis-common-protos==1.59.0
   > 239c239
   > < grpc-google-iam-v1==0.12.4
   > ---
   > > grpc-google-iam-v1==0.12.6
   > 330c330
   > < neo4j==5.6.0
   > ---
   > > neo4j==5.7.0
   > 349c349
   > < oracledb==1.2.2
   > ---
   > > oracledb==1.3.0
   > 355c355
   > < pandas-gbq==0.17.9
   > ---
   > > pandas-gbq==0.19.1
   > 383,384c383,384
   > < proto-plus==1.19.6
   > < protobuf==3.20.0
   > ---
   > > proto-plus==1.22.2
   > > protobuf==3.20.3
   > 420c420
   > < pytest-instafail==0.4.2
   > ---
   > > pytest-instafail==0.5.0
   > ```
   > 
   > Let's see if the tests pass.,
   
   yes, it will upgrade other SDK, because google-ads forced us to for example 
install protobuf<4. When you removed it from providers.yaml we don't have that 
restriction and SDK can be installed in latests version without conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to