potiuk commented on PR #30403: URL: https://github.com/apache/airflow/pull/30403#issuecomment-1494109927
> yes, it will upgrade other SDK, because google-ads forced us to for example install protobuf<4. When you removed it from providers.yaml we don't have that restriction and SDK can be installed in latests version without conflicts. It's not even protobuf (yet). Those are other limits (I think limitation google ads put on `google-api-core` mainly) that holds other libraries back. I decided to keep the limitations back because of potentialy small breaking changes (I had to fix a few tests and even make a few changes to make the tests pass and I did not feel comfortable doing that at the same time, especiallly as I know you are fixing those in #30067 so it's better to release all those there. For now. I've added those limits here: https://github.com/apache/airflow/blob/main/airflow/providers/google/provider.yaml#L80 ``` # needed by vendored-in google-ads - googleapis-common-protos<2.0.0,>=1.5.8 - google-api-core==2.8.2 - google-auth-oauthlib<1.0.0,>=0.3.0 - grpcio<2.0.0,>=1.38.1 - grpcio-status<2.0.0,>=1.38.1 - PyYAML<7.0,>=5.1 - proto-plus==1.19.6 - protobuf!=3.18.*,!=3.19.*,<=3.20.0,>=3.12.0 ``` So just a watchout you will have to remove those when you work on #30067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
