[
https://issues.apache.org/jira/browse/AIRFLOW-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888855#comment-16888855
]
ASF GitHub Bot commented on AIRFLOW-4775:
-----------------------------------------
nuclearpinguin commented on pull request #5613: [AIRFLOW-4775] Fix incorrect
parameter order in GceHook
URL: https://github.com/apache/airflow/pull/5613
Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-4775
### Description
- [ ] Fixes incorrect parameter order in
GceHook._wait_for_operation_to_complete
method and adds additional tests.
### Tests
- [ ] My PR adds the following unit tests
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GceHook ommited num_retries parameter
> -------------------------------------
>
> Key: AIRFLOW-4775
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4775
> Project: Apache Airflow
> Issue Type: Bug
> Components: gcp
> Affects Versions: 1.10.3
> Reporter: Kamil Bregula
> Priority: Major
>
> The _check_global_operation_status method is not correctly executed in the
> GceHook hook. The num_retries parameter has been omitted.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
