eladkal commented on code in PR #30487:
URL: https://github.com/apache/airflow/pull/30487#discussion_r1160745876


##########
docs/apache-airflow/howto/set-up-database.rst:
##########
@@ -300,6 +300,14 @@ We recommend using the ``mysqlclient`` driver and 
specifying it in your SqlAlche
 
 We also support the ``mysql-connector-python`` driver, which lets you connect 
through SSL
 without any cert options provided.
+Unfortunately, this package depends on outdated version of ``protobuf<4.0``  
which is no longer supported.
+If you wish to use ``mysql-connector-python`` driver, please install it with 
pip.
+
+.. code-block:: text
+
+   $ pip install mysql-connector-python

Review Comment:
   Why? We enabled it as extra so the install should be with the extra



##########
docs/apache-airflow/howto/set-up-database.rst:
##########
@@ -300,6 +300,14 @@ We recommend using the ``mysqlclient`` driver and 
specifying it in your SqlAlche
 
 We also support the ``mysql-connector-python`` driver, which lets you connect 
through SSL
 without any cert options provided.
+Unfortunately, this package depends on outdated version of ``protobuf<4.0``  
which is no longer supported.

Review Comment:
   I think we should just explain that we have an extra option for another 
mysql client and in the extra info below we can explain that users should be 
aware of proto issue with link to the proto update request we submitted to the 
lib.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to