potiuk commented on PR #30487: URL: https://github.com/apache/airflow/pull/30487#issuecomment-1500364047
I am not 100% sure if it is breaking to be honest. We already agreed that dependency changes are non-breaking and assuming somoene already has installed mysql-connector-python, it will continue to work after the upgrade. Breaking means - if somoene upgrades the provider, things will break. Which is not necessarily true - if someone upgrade from past provider, things will continue to work (because the user will have mysql-connector-python already installed). The user might be prevented from installing the newer provider (because of protobuf for example) but this also does not mean that it's a "breaking change". I think, technically speaking, it's not "strongly" breaking - the usual "breaking" pattern when things break when you upgrade does not "technically" apply. There are other scenarios where things might break - for example when you upgrade airflow image and you expect mysql operators to continue to work. But also technically it is not breaking, because images are "convenience" binaries, and while people might use them in charts, they are not even versioned with breakin/non-breaking (because they contain combination of airflow + possibly breaking providers). So I am not really sure if we should classify that change as breaking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
