potiuk commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1161337843
##########
airflow/models/skipmixin.py:
##########
@@ -143,7 +146,12 @@ def skip(
session=session,
)
- def skip_all_except(self, ti: TaskInstance, branch_task_ids: None | str |
Iterable[str]):
+ def skip_all_except(
+ self,
+ ti: TaskInstance | TaskInstancePydantic,
+ task: BaseOperator,
Review Comment:
Yeah You are likely right, I will bring it back.
The problem is that task attribute cannot be **really** defined in
TaskInstancePydantic and we should not be serialized - becuase it is only set
and used during execution preparation. So rather than retrieving and
serializing it fro from the DB it is populated during execution of the task in
local task job and I could not find a good way to add dynamically a
non-serializable attribute to TaskInstancePydantic.
But this part will be handled later when we extract the methods from
task_instance to be AIP-44 compliant, so we can handle it then. For now I will
add # type: ignore to handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
