potiuk commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1161339755


##########
airflow/jobs/base_job.py:
##########


Review Comment:
   Ah. I looked it up and I **just** realized that the table name IS actually 
JOB. I have not realized it, so yeah - removing `base_` sounds like great idea.
   
   So I can attempt to change it indeed to be just `job`. I do not want to do 
it in this PR as I want to avoid renaming modules while changing them to make 
it easier to review changes in PR, but the next PR in the series #30302  where 
I ONLY rename job_runner modules, wll be ideal to make such rename. I will try 
to modify #30302 and see if I can change it there and see if it also will not 
impact the follow-up PRS (worst case -> I can add one more extra PR at the end 
to rename it).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to