notatallshaw-gts commented on PR #30495: URL: https://github.com/apache/airflow/pull/30495#issuecomment-1502159633
> About the if/else, I don't really know how we should handle it. Either we pre-imprt both branches, or we import none. I'd lean towards importing none because this is just an optim, and we want to do the 10% effort to handle 90% of the cases I'd say ? I agree, neither solution is completely correct, probably better to err on the side of not importing things because that's safer, e.g. it could be behind an if statement because the import has side effects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
