uranusjr commented on code in PR #30495:
URL: https://github.com/apache/airflow/pull/30495#discussion_r1163964902
##########
airflow/dag_processing/processor.py:
##########
@@ -187,6 +188,19 @@ def _handle_dag_file_processing():
def start(self) -> None:
"""Launch the process and start processing the DAG."""
+ import importlib
+
+ modules = get_airflow_modules_in(self.file_path)
+ for module in modules:
+ try:
+ importlib.import_module(module)
+ except Exception as e:
+ # only log as warning because an error here is not preventing
anything from working,
+ # and if it's serious, it's going to be surfaced to the user
when the dag is actually parsed.
+ self.log.warning(
+ f"error when try to pre-import module '{module}' found in
{self.file_path}: {e}"
+ )
Review Comment:
https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
