ferruzzi commented on code in PR #30496:
URL: https://github.com/apache/airflow/pull/30496#discussion_r1163155058
##########
airflow/dag_processing/processor.py:
##########
@@ -534,7 +535,9 @@ def manage_slas(cls, dag_folder, dag_id: str, session:
Session = NEW_SESSION) ->
email_sent = True
notification_sent = True
except Exception:
- Stats.incr("sla_email_notification_failure",
tags={"dag_id": dag.dag_id})
+ Stats.incr(
+ "sla_email_notification_failure", tags={"dag_id":
dag.dag_id, "email": str(emails)}
Review Comment:
I'm actually going to phone-a-friend on that one. I pulled that directly
from @howardyoo 's POC and noticed it was one he added. Howard, thoughts? Is
there a specific reason you wanted that in there or can/should I drop it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
