howardyoo commented on code in PR #30496:
URL: https://github.com/apache/airflow/pull/30496#discussion_r1163229238
##########
airflow/models/taskinstance.py:
##########
@@ -540,6 +540,10 @@ def __init__(
# can be changed when calling 'run'
self.test_mode = False
+ @property
+ def stats_tags(self) -> dict[str, str]:
+ return prune_dict({"dag_id": self.dag_id, "run_id": str(self.run_id),
"task_id": self.task_id})
Review Comment:
> isn't run_ID a meaningless autogenerated number ? If so, I think it'd add
little value to the metric, while adding a lot of cardinality, making the costs
📈 for users
I don't think it's a meaningless, but yes - it is auto-generated. For
example, `scheduled__2023-04-11T19:10:00+00:00` but I have to agree, that it
will generate unnecessary cardinality since each of these will attribute to a
distinct time series and users would probably going to see dots instead of
lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
