ferruzzi commented on code in PR #30496:
URL: https://github.com/apache/airflow/pull/30496#discussion_r1163509768
##########
airflow/dag_processing/processor.py:
##########
@@ -174,6 +174,7 @@ def _handle_dag_file_processing():
), Stats.timer() as timer:
_handle_dag_file_processing()
log.info("Processing %s took %.3f seconds", file_path,
timer.duration)
+ Stats.timing("dag.processor.parse.time", dt=timer.duration,
tags={"file_path": file_path})
Review Comment:
Reverted this change in
https://github.com/apache/airflow/pull/30496/commits/3c32c7df8d17fa685011f7f6a39b40fee944315b
##########
airflow/executors/base_executor.py:
##########
@@ -216,9 +216,10 @@ def heartbeat(self) -> None:
self.log.debug("%s in queue", num_queued_tasks)
self.log.debug("%s open slots", open_slots)
- Stats.gauge("executor.open_slots", open_slots)
- Stats.gauge("executor.queued_tasks", num_queued_tasks)
- Stats.gauge("executor.running_tasks", num_running_tasks)
+ name = {"name": self.__class__.__name__}
+ Stats.gauge("executor.open_slots", value=open_slots, tags={"status":
"open", **name})
+ Stats.gauge("executor.queued_tasks", value=num_queued_tasks,
tags={"status": "queued", **name})
+ Stats.gauge("executor.running_tasks", value=num_running_tasks,
tags={"status": "running", **name})
Review Comment:
Fixed this in
https://github.com/apache/airflow/pull/30496/commits/3c32c7df8d17fa685011f7f6a39b40fee944315b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
