ashb commented on code in PR #30478:
URL: https://github.com/apache/airflow/pull/30478#discussion_r1166555842
##########
airflow/www/views.py:
##########
@@ -2474,6 +2506,7 @@ def confirm(self):
dag_run_id = args.get("dag_run_id")
state = args.get("state")
origin = get_safe_url(args.get("origin"))
+ group_id = args.get("group_id")
Review Comment:
I do wonder if we need separate argument for this -- task_ids and group_ids
can never overlap, so given an ID we should be able to find it in the DAG and
work out if it's a task or a group...
##########
airflow/www/views.py:
##########
@@ -2474,6 +2506,7 @@ def confirm(self):
dag_run_id = args.get("dag_run_id")
state = args.get("state")
origin = get_safe_url(args.get("origin"))
+ group_id = args.get("group_id")
Review Comment:
I do wonder if we need separate argument for this -- task_ids and group_ids
can never overlap, so given an ID we should be able to find it in the DAG and
work out if it's a task or a group. We could call the parameter `node_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
