tquazi commented on code in PR #30478:
URL: https://github.com/apache/airflow/pull/30478#discussion_r1167620718
##########
airflow/www/views.py:
##########
@@ -2474,6 +2506,7 @@ def confirm(self):
dag_run_id = args.get("dag_run_id")
state = args.get("state")
origin = get_safe_url(args.get("origin"))
+ group_id = args.get("group_id")
Review Comment:
We follow similar pattern for ClearTask.
https://github.com/apache/airflow/blob/main/airflow/www/views.py#L2152
Let me know if this needs to change as well.
Having a single parameter `node_id` makes more sense, but we will have to
add logic to find if it is a task or a group. From the views we already know if
it is a group or not, can we send node_id and isGroup parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
