eladkal commented on code in PR #30718:
URL: https://github.com/apache/airflow/pull/30718#discussion_r1170501085
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -191,6 +191,8 @@ class KubernetesPodOperator(BaseOperator):
:param is_delete_operator_pod: What to do when the pod reaches its final
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
+ :param delete_when_fails: If False, and is_delete_operator_pod is set to
True
Review Comment:
This feels a bit complicated.
I think we should consider replace is_delete_operator with:
action_on_finish that supports several modes. For example: delete_pod,
delete_pod_success
That way you dont need to work hard to understand the combinationa of flags,
the mode is self explanatory.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
