hussein-awala commented on code in PR #30718:
URL: https://github.com/apache/airflow/pull/30718#discussion_r1170592987


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -191,6 +191,8 @@ class KubernetesPodOperator(BaseOperator):
     :param is_delete_operator_pod: What to do when the pod reaches its final
         state, or the execution is interrupted. If True (default), delete the
         pod; if False, leave the pod.
+    :param delete_when_fails: If False, and is_delete_operator_pod is set to 
True

Review Comment:
   My first thought was doing something similar to #29394, but I hesitated to 
deprecate `is_delete_operator_pod`, but yes, these flags may confuse users. 
I'll implement the argument you propose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to