vandonr-amz commented on code in PR #30757:
URL: https://github.com/apache/airflow/pull/30757#discussion_r1172887183
##########
tests/system/providers/amazon/aws/example_emr_serverless.py:
##########
@@ -100,13 +101,14 @@
configuration_overrides=SPARK_CONFIGURATION_OVERRIDES,
)
# [END howto_operator_emr_serverless_start_job]
- start_job.waiter_check_interval_seconds = 10
+ start_job.wait_for_completion = False
# [START howto_sensor_emr_serverless_job]
wait_for_job = EmrServerlessJobSensor(
task_id="wait_for_job",
application_id=emr_serverless_app_id,
job_run_id=start_job.output,
+ target_states=EmrServerlessHook.JOB_INTERMEDIATE_STATES,
Review Comment:
I think it's nice to have it in the doc example ? It's pretty
self-explanatory (but not necessary indeed).
I'd think it's a good way to highlight some params to put them in the
example... But maybe some users just copy paste this and try to adapt it to
their needs, in which case it could be confusing ? idk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
