o-nikolas commented on code in PR #30757:
URL: https://github.com/apache/airflow/pull/30757#discussion_r1173169289
##########
tests/system/providers/amazon/aws/example_emr_serverless.py:
##########
@@ -100,13 +101,14 @@
configuration_overrides=SPARK_CONFIGURATION_OVERRIDES,
)
# [END howto_operator_emr_serverless_start_job]
- start_job.waiter_check_interval_seconds = 10
+ start_job.wait_for_completion = False
# [START howto_sensor_emr_serverless_job]
wait_for_job = EmrServerlessJobSensor(
task_id="wait_for_job",
application_id=emr_serverless_app_id,
job_run_id=start_job.output,
+ target_states=EmrServerlessHook.JOB_INTERMEDIATE_STATES,
Review Comment:
I land on the side of this being confusing. I think most folks would assume
that the test is running the jobs to completion unless otherwise stated, but
it's helpful to know that they can provide states, so maybe just add a short
comment above this line to explain what's happening here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
