vincbeck commented on code in PR #30756: URL: https://github.com/apache/airflow/pull/30756#discussion_r1173056251
########## airflow/providers/amazon/aws/hooks/logs.py: ########## @@ -25,6 +25,13 @@ from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook +# From AWS team the correct way to check for end of stream is that if the value of nextForwardToken is same +# in subsequent calls +# The issue with this approach is, it can take a huge amount of time (e.g. 20 seconds) to retrieve logs +# As an intermediate solution, we decided to stop fetching logs if 3 consecutive responses are empty Review Comment: I like your changes :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
