o-nikolas commented on code in PR #30756:
URL: https://github.com/apache/airflow/pull/30756#discussion_r1173097353
##########
airflow/providers/amazon/aws/hooks/logs.py:
##########
@@ -96,7 +104,15 @@ def get_log_events(
yield from events
- if next_token != response["nextForwardToken"]:
+ if "nextForwardToken" not in response:
+ num_consecutive_empty_response += 1
Review Comment:
I actually missed this too the first time I looked at it. But if you look at
the top of that diff you linked the while loop statement actually changed as
well. It used to be:
```
while event_count > 0:
```
So it was the while loop breaking when event_count was zero in most all
cases, not the token (because again the token is always present basically).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
