neil90 opened a new pull request #5635: [Airflow 4923] Fix Databricks hook leaks API secret in logs URL: https://github.com/apache/airflow/pull/5635 When users store token in the extra field for a Databricks connection the DatabricksHook leaks the token to the airflow logs. Adding ability(and updating docs) for the hook to get the host from the extra json will not cause the Basehook.get_connection to send the extra json to the airflow logs since 'host' field will be empty. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" https://issues.apache.org/jira/browse/AIRFLOW-4923 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: When users store token in the extra field for a Databricks connection the DatabricksHook leaks the token to the airflow logs. Adding ability(and updating docs) for the hook to get the host from the extra json will not cause the Basehook.get_connection to send the extra json to the airflow logs since 'host' field will be empty. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Updated testcase to look for host in extra json tests.contrib.hooks.test_databricks_hook:DatabricksHookTokenTest.test_submit_run ### Commits - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release ### Code Quality - [ ] Passes `flake8`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
