potiuk commented on PR #30758:
URL: https://github.com/apache/airflow/pull/30758#issuecomment-1518548531
> Great to hear it's had such a positive impact on Airflow's workflow!
>
> FYI in my experiments I could get the new resolver to hang when faced with
very complicated requirements (significantly more than
`apache-airflow[all]={version}`) and there was no actual resolution, but I have
yet to find any real-world requirements that trigger it.
I will definitely keep an eye on that one :).
FYI. We basically perform eager-upgrade dependency resolution for
650+dependencies of Airflow (including transitive ones) for every "main" build
we have and the result of it is kept in the repo every time it changes. See
the history here: https://github.com/apache/airflow/commits/constraints-main .
It's not a "from the scratch" dependency resolution - it is based on the
previously resolved dependencies, but so far it happened (not too often but
when it happened, it had to be solved quickly) that the dependency resolver has
been stuck in the endless (or at least extremely long) backtracking loop. So
we had to introduce our own tool (removed in this PR) tha was tracking what has
changed (i.e. which dependencies changed from last successful resolution) so
that we could bisect the one that causes it (the output usually was not
helpful) and fix the problem by adding some extra limits manually (also removed
in this PR) .
So we will let you know for sure if we hit similar problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
