potiuk commented on code in PR #30825:
URL: https://github.com/apache/airflow/pull/30825#discussion_r1174667421
##########
dev/breeze/SELECTIVE_CHECKS.md:
##########
@@ -103,51 +103,57 @@ The logic implements the following rules:
* if `Image building` is disabled, only basic pre-commits are enabled - no
'image-depending` pre-commits
are enabled.
* If there are some setup files changed, `upgrade to newer dependencies` is
enabled.
+* If docs are build, the `docs-filter` will determine which docs packages to
build. This is based on
+ several criteria: if any of the airflow core, charts, docker-stack,
providers files or docs have changed,
Review Comment:
I also added another test case - speecifically for common-sql, to show what
happens when any of the common/sql python files change (this case is also
handled - because changes in any of the python files in the dependent provider
might impact generated documentation due to auto-api generated documentation
from docstrings.
But the change in selective_checks I implemented is nicely handking this
case too
```
pytest.param(
("airflow/providers/common/sql/common_sql_python.py",),
{
"docs-filter": "--package-filter apache-airflow "
"--package-filter apache-airflow-providers-amazon "
"--package-filter apache-airflow-providers-apache-drill "
"--package-filter apache-airflow-providers-apache-druid "
"--package-filter apache-airflow-providers-apache-hive "
"--package-filter apache-airflow-providers-apache-impala "
"--package-filter apache-airflow-providers-apache-pinot "
"--package-filter apache-airflow-providers-common-sql "
"--package-filter apache-airflow-providers-databricks "
"--package-filter apache-airflow-providers-elasticsearch "
"--package-filter apache-airflow-providers-exasol "
"--package-filter apache-airflow-providers-google "
"--package-filter apache-airflow-providers-jdbc "
"--package-filter apache-airflow-providers-microsoft-mssql "
"--package-filter apache-airflow-providers-mysql "
"--package-filter apache-airflow-providers-odbc "
"--package-filter apache-airflow-providers-oracle "
"--package-filter apache-airflow-providers-postgres "
"--package-filter apache-airflow-providers-presto "
"--package-filter apache-airflow-providers-qubole "
"--package-filter apache-airflow-providers-slack "
"--package-filter apache-airflow-providers-snowflake "
"--package-filter apache-airflow-providers-sqlite "
"--package-filter apache-airflow-providers-trino "
"--package-filter apache-airflow-providers-vertica",
},
id="Common SQL provider package python files changed changed",
),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
