potiuk commented on code in PR #30825:
URL: https://github.com/apache/airflow/pull/30825#discussion_r1174669450
##########
dev/breeze/SELECTIVE_CHECKS.md:
##########
@@ -103,51 +103,57 @@ The logic implements the following rules:
* if `Image building` is disabled, only basic pre-commits are enabled - no
'image-depending` pre-commits
are enabled.
* If there are some setup files changed, `upgrade to newer dependencies` is
enabled.
+* If docs are build, the `docs-filter` will determine which docs packages to
build. This is based on
+ several criteria: if any of the airflow core, charts, docker-stack,
providers files or docs have changed,
Review Comment:
BTW. The whole PR here is based on the observation, that there is no way
provider documentation depends on a different provider, if the provider itsefl
does not depend on it (i.e. imports the other provider) - we already have that
information and we are making good use of it.
Of course you could like make a reference from provider A to B is A does not
depend on B, but that would be rather stupid to do and we would have found it
in the "canary" build which always runs "full" build regardless.
There is an updated tests that makes sure this is happening too
(`docs-filter: ""` means that all docs packages are built):
```
pytest.param(
("INTHEWILD.md",),
(),
"main",
{
"all-python-versions": "['3.7', '3.8', '3.9', '3.10']",
"all-python-versions-list-as-string": "3.7 3.8 3.9 3.10",
"image-build": "true",
"needs-helm-tests": "true",
"run-tests": "true",
"docs-build": "true",
"docs-filter": "",
"upgrade-to-newer-dependencies": "true",
"parallel-test-types": "Core Providers[-amazon,google] Other
Providers[amazon] WWW "
"API Always CLI Providers[google]",
},
id="All tests run on push even if unimportant file changed",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
