eladkal commented on code in PR #30166:
URL: https://github.com/apache/airflow/pull/30166#discussion_r1177839525
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -585,41 +622,70 @@ def __init__(
partition_clause: str | None = None,
conn_id: str | None = None,
database: str | None = None,
+ accept_none: bool = True,
Review Comment:
Why can't we deprecate first?
SQLTableCheckOperator - We can add new parameter for with default value False
SQLColumnCheckOperator - Raise deprecation warning that default value will
be changed in future versions to False.
In the future we can release common.sql provider with major release that
changes the default value.
We are very careful with major releases of common.sql but this one will be
fine. WDYT @potiuk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
