eladkal commented on code in PR #30166:
URL: https://github.com/apache/airflow/pull/30166#discussion_r1180124268
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -585,41 +622,70 @@ def __init__(
partition_clause: str | None = None,
conn_id: str | None = None,
database: str | None = None,
+ accept_none: bool = True,
Review Comment:
> But if you think it's likely that someone would fall into backwards
compatibility there, and it's worth it - yeah. it could be done.
We promise to preserve backward compabity unless with major version.
If we think this is a very rare case then we can do a major release without
deprecating. Assuming we expect this change to effect very small number of
users that can be OK to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
