ferruzzi commented on code in PR #30873:
URL: https://github.com/apache/airflow/pull/30873#discussion_r1178494858
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -306,3 +306,13 @@ def _log_return_code_metric(self, return_code: int):
"local_task_job.task_exit."
f"{self.job.id}.{self.task_instance.dag_id}.{self.task_instance.task_id}.{return_code}"
)
+ # Same metric with tagging
+ Stats.incr(
Review Comment:
That was one of the ideas I had for the Metrics Registry, actually. It
could be used to record the template used to generate the old names and that
template could be used to extract it down into the new names. Unfortunately
there isn't a great deal of consistency on the names at this point so it's not
as easy as just doing a split(), sadly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
