ferruzzi commented on code in PR #30873:
URL: https://github.com/apache/airflow/pull/30873#discussion_r1178495728
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -306,3 +306,13 @@ def _log_return_code_metric(self, return_code: int):
"local_task_job.task_exit."
f"{self.job.id}.{self.task_instance.dag_id}.{self.task_instance.task_id}.{return_code}"
)
+ # Same metric with tagging
+ Stats.incr(
Review Comment:
Or maybe it can... if i pass in the new name with the attributes/tags, then
in incr() just emit it that way and then emit it concatenated all together...
but then I'd have to worry about sorting order of the items in
`attributes`which might be a different nightmare...
Maybe adjust incr() so it takes an optional "back-compat-name" parameter?
If it exists, then emit both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
