pankajastro commented on code in PR #30865:
URL: https://github.com/apache/airflow/pull/30865#discussion_r1178715743
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -190,11 +197,31 @@ def execute(self, context: Context):
"""
self.submit_job(context)
+ if self.deferrable:
+ self.defer(
+ timeout=self.execution_timeout,
+ trigger=BatchOperatorTrigger(
+ job_id=self.job_id,
+ max_retries=self.max_retries or 10,
Review Comment:
I understand your concern.
currently, max_reries is of type optional init and in BatchClientHook we do`
self.max_retries = max_retries or self.MAX_RETRIES` I feel we should change the
type to int in init something like `def __init__(self, max_retries: int =
MAX_RETRIES, ...)` but is it ok if we take it in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
