howardyoo commented on PR #30873: URL: https://github.com/apache/airflow/pull/30873#issuecomment-1526058794
Why not add ‘sampling rate’ instead of just ‘percentage?’ I think it might be more concise if we could describe it as “value between 0 and 1 that represents the sampled rate at which the metric is going to be emitted.”Sent from my iPhoneOn Apr 27, 2023, at 11:57 AM, D. Ferruzzi ***@***.***> wrote: @ferruzzi commented on this pull request. In airflow/metrics/otel_logger.py: > + :param rate: Value between 0 and 1 representing the "percentage" of + the time to emit the metric where 1 = 100%. Still trying to think of a better way to phrase this, open to suggestions. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
