ferruzzi commented on code in PR #30873:
URL: https://github.com/apache/airflow/pull/30873#discussion_r1179722756
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -306,3 +306,13 @@ def _log_return_code_metric(self, return_code: int):
"local_task_job.task_exit."
f"{self.job.id}.{self.task_instance.dag_id}.{self.task_instance.task_id}.{return_code}"
)
+ # Same metric with tagging
+ Stats.incr(
Review Comment:
I just saw that last comment. Yeah, it would be up to whoever is adding a
new metric to know about the character limit on the name. Maybe have a look at
the latest implementation of incr() and let me know what you think. If we go
with the current technique, then we can get rid of these double calls all over
the place and consolidate them to `incr("new_name, tags=tags,
back_compat_name=f'name_{with}_{embedded}_{tags}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
