potiuk commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1528818513
Just a thought. @o-nikolas . MAYBE there is a way to split that one into two prs -> one extracting/renaming code/methods, maybe extracting the common k8S executor types, and another moving stuff arround between files and splitting it? This way the "move" will be easier to review as it will be basically same code here and there, just moved around. I think this is what makes it difficult to review that it is all-in-one. Also it might be in the future easier to find any problems if you do it this way. This is the technique i used in the "base_job" refactoring case and I think it makes a lot of sense ? Would it be possible that you give it a try ? I am not trying to make more work for you BTW, Just thinking about the case when we will find some bugs in the future and will want to track the changes to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
