o-nikolas commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1529345525
In this particular case, I really do feel strongly that it is unwarranted to split this particular PR further. There have been many PRs before of refactored code which are pages long. This change set is really just moving code from `kubernetes_executor.py` to two other modules (without changing any of the functionality). Some moved imports (closer to use) and a single helper function are the only modification to `kubernetes_executor.py` and they are easy to tell apart because they are the green/additions in the diff for that module (all the other big red/deletions are the aforementioned migration of code). @uranusjr gave it a :+1: (other than a small nit on module name which I'm waiting to hear back on), hopefully some others can have a look. Perhaps @jedcunningham, since he's worked on the kubernetes executor lately and will be familiar with the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
